Use absolute paths in #line directives generated #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple .ino files in a sketch are concatenated together, adding #line directives so error messages refer to the original filenames. However, these directives used plain filenames, without a path. Since these filenames end up in the debug info as-is, this complicates using a debugger on the resulting .elf file. Using full pathnames fixes this. The tests are updated to expect full paths as well. This uses the text/template package to process the sketch file, allowing it access to the full context. This is a bit overkill, but it is easy and might be useful for more complex testcases later. This fixes arduino/Arduino#3746. Signed-off-by: Matthijs Kooijman <[email protected]>
ffissore
added a commit
that referenced
this pull request
Sep 24, 2015
Use absolute paths in #line directives generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple .ino files in a sketch are concatenated together, adding #line
directives so error messages refer to the original filenames. However,
these directives used plain filenames, without a path. Since these
filenames end up in the debug info as-is, this complicates using a
debugger on the resulting .elf file. Using full pathnames fixes this.
The tests are updated to expect full paths as well. This uses the
text/template package to process the sketch file, allowing it access to
the full context. This is a bit overkill, but it is easy and might be
useful for more complex testcases later.
This fixes arduino/Arduino#3746.
Signed-off-by: Matthijs Kooijman [email protected]